search

dan200 / ComputerCraft

Programmable Computers for Minecraft
Other
964 stars 199 forks source link

Change height checks to integrated MC method #601

Open Shad0wlife opened 4 years ago

Shad0wlife commented 4 years ago

This effectively still checks if the target position is 0<=y<256, just as separate checks for 0 and world.getHeight() would do. But by using this, mods like CubicChunks which modify the world's height limits can change the result of the world.isOutsideBuildHeight() for easy compatibility.

vico93 commented 4 years ago

Could make a copy of this PR for CC:Tweaked too (if this bugfix already wasnt added there)?

SquidDev commented 4 years ago

CC:T should have these patches already. That said, I've never actually tested whether it's sufficient to ensure compat with CubicChunks.

Shad0wlife commented 4 years ago

You are right, thank you. I did not know about CC:Tweaked though, is there any web presence other than your github? When looking for the current version of CC, I did not find anything about it either.

EDIT: Ok, found it on Curseforge now that I knew where to look. I hope it gets known better!