search

dan5py / turborepo-shadcn-ui

Turborepo starter with shadcn/ui pre-configured.
MIT License
466 stars 89 forks source link

How to implement Dark mode? #7

Closed kernelsoe closed 1 year ago

kernelsoe commented 1 year ago

Thanks for this template!

Shadcn's dark mode works well inside apps/ workspace. But how can we add dark mode inside the packages/ui?

Doc says to wrap ThemeProvider in layout.

kernelsoe commented 1 year ago

Oh, I was able to add dark mode by wrapping ThemeProvider in respective apps/ layouts. 😄 Shall I open PR?

dan5py commented 1 year ago

Hi @kernelsoe, thanks for wanting to contribute but I think it would be better without ThemeProvider by default. I feel it's best to let anyone install it later if they need to.

kernelsoe commented 1 year ago

@dan5py Thanks for the feedback! I'll close this. :)