search

danStich / shadia

shadia: dam passage performance standard models for R
https://shadia-ui.github.io/index.html
GNU General Public License v3.0
6 stars 1 forks source link

populationSize doesn't match sum of PUS #11

Closed danStich closed 6 years ago

danStich commented 6 years ago

populationSize is calculated as the sum of males and females across production units before application of pre-spawn mortality, fishing mortality, and post-spawn mortality.

Production-unit population sizes are currently calculated after application of those rates.

Should re-code R files used in penobscotRiverModel() and merrimackRiverModel() so that the sum of production-unit spawners equals populationSize.

danStich commented 6 years ago

This issue has been resolved in all three of the models. All PU-specific population sizes are now collected prior to application of any pre- or post-spawning mortality rates, and the sum of PU-specific population sizes matches the overall population size for spawners with zero rounding errors.