search

danStich / shadia

shadia: dam passage performance standard models for R
https://shadia-ui.github.io/index.html
GNU General Public License v3.0
6 stars 1 forks source link

Fish not moving into NY #16

Closed danStich closed 6 years ago

danStich commented 6 years ago

Fish in the Susquehanna River model are not moving into NY waters in the 'North Branch' movement route (upstream_path == 4). Thought that it was due to temperatures or long distance from mouth of river, but I cranked up movement speed parameters and closed off other routes, and fish are still not making it. Might be fine, but need to take a closer look.

danStich commented 6 years ago

Found potential issue in line 543 of inner-loop-sampling. Was using maxrkm[1] where I think it should have said maxrkm[i]. Made the change, and it started throwing errors about dimension mismatches.

danStich commented 6 years ago

Found a second instance of PU numbering error based on name stripping. Fixed.