danStich / shadia

shadia: dam passage performance standard models for R
https://shadia-ui.github.io/index.html
GNU General Public License v3.0
6 stars 1 forks source link

Timing for watershed-scale models #25

Closed danStich closed 5 years ago

danStich commented 5 years ago

Related to issue #24.

It appears that timing values for the first dam are not recycled at remaining dams as intended when watershed = TRUE.

Temporary workaround: can pre-sample the value for timing and then pass to function using object name, like this:

# Sample timing
times <- sample(c(1,2,3),1)  

# Run the model
res1 <- connecticutRiverModel(
  nRuns = 1,
  nYears = 2,
  timing = list(times, times, times, times, times),
  upstream = list(
    holyoke = c(0.50, 0.60, 0.70),
    cabot = 1,
    spillway = 1,
    gatehouse = 1,
    vernon = 1
  ),
  downstream = list(
    holyoke = c(0.80, 0.90, 0.95),
    cabot = 1,
    gatehouse= 1,
    vernon = 1
  ),
  northfield = list(
    turnersA = 0.95,
    turnersJ = 0.95,
    vernonA = 0.95,
    vernonJ = 0.95
  ),
  pSpillway = 1,
  inRiverF = 0,
  commercialF = 0,
  bycatchF = 0,
  indirect = 1,
  latent = 1,
  watershed = TRUE
  )