danStich / shadia

shadia: dam passage performance standard models for R
https://shadia-ui.github.io/index.html
GNU General Public License v3.0
6 stars 1 forks source link

Huge numbers in first PU for `mohawkHudsonRiverModel()` #40

Closed danStich closed 4 years ago

danStich commented 4 years ago

The number of spawners being returned in the first downstream production unit seems unrealistically high in this model. Possibly related to similar bug/data issue #42 in kennebecRiverModel()

danStich commented 4 years ago

Not related to previous Kennebec River problem.

danStich commented 4 years ago

Was combination of erroneous habitat value for PU_7A in "R/defineHabitat.R" for this river (line 182) and huge habitat values for PU_1A in "R/defineHabitat.R" (lines 182 and 184). Accounted for latter by subtracting habitat lost to dredge-and-fill according to Hudson River American Shad Recovery Plan (NYSDEC 2010). I also discounted PU_1A about 60% (x 0.40) to account for extent of salt and brackishwater in lower river (all of which is tidal).