search

danTapps / homebridge-hubitat-makerapi

Apache License 2.0
29 stars 15 forks source link

GUI Configuration: Created config.schema.json #12

Closed AppleTechy closed 4 years ago

AppleTechy commented 4 years ago

Created config.schema.json which would allow configuration via GUI in Config-UI-X. All configuration settings can be set via the GUI except excluded_attributes and excluded_capabilities. If those were to be configured via GUI it would require a change in how users configure them in the config.json. See here for necessary changes . It would be possible put this would break backwards compatibility with previous config.json version. Another breaking change that would make GUI configuration simpler would be reworking how the boolean values in theconfig.json work. If GUI configuration is used boolean values will be put into config.json no matter if they are the same as the defaults the plugin uses.
This PR has no breaking changes. These breaking changes are just being discussed for possibly another PR later to allow better configuration via GUI.

AppleTechy commented 4 years ago

Do not merge. I am going to go ahead a close this PR for now until I figure out the dependency situation or give up. The latest commit broke the plugin due to a type error during the updating of dependencies. I will reopen once it gets sorted out or I revert it.