search

danabr / multipart-parser

A multipart parser written in Ruby
MIT License
17 stars 10 forks source link

Ruby 1.9 support #4

Closed expandrive closed 12 years ago

expandrive commented 12 years ago

Cast the keys of the boundary_char hash to type String rather than Fixednum to correctly support Ruby 1.8 and 1.9

danabr commented 12 years ago

Thanks for your contribution, Jeff!

I haven't had a chance to test this myself. Did this solve any of the failing testcases reported in issue #3?

//Daniel

expandrive commented 12 years ago

It fixes the first and last test in issue #3, but the 6th test still fails - haven't dug deeply enough to figure out why. I did notice that the failure was introduced within the last 5 commits or so.

danabr commented 12 years ago

Glad to hear that. I haven't had much time to put into it, so I mostly just merge any fixes people come along with. Do you want a new release of the gem, or do you use it directly from github?

//Daniel

On 08/21/2012 02:36 PM, ExpanDrive Inc wrote:

It fixes the first and last test in issue #3 https://github.com/danabr/multipart-parser/issues/3, but the 6th test still fails - haven't dug deep enough to figure out why.

— Reply to this email directly or view it on GitHub https://github.com/danabr/multipart-parser/pull/4#issuecomment-7899553.

expandrive commented 12 years ago

Thanks to bundler, I am pulling directly from GitHub.

A new release wouldn't be a bad idea, since part_end events fail to fire under Ruby 1.9 without the patch

danabr commented 12 years ago

Ok, I'll try to find some time for doing it tomorrow.

//Daniel

On 08/21/2012 02:40 PM, ExpanDrive Inc wrote:

Thanks to bundler, I am pulling directly from GitHub.

A new release wouldn't be a bad idea, since part_end events fail to fire under Ruby 1.9 without the patch

— Reply to this email directly or view it on GitHub https://github.com/danabr/multipart-parser/pull/4#issuecomment-7899656.

danabr commented 12 years ago

New version is out now.