search

danaj / Math-Prime-Util-GMP

Perl prime number module using XS/GMP
Other
17 stars 9 forks source link

add_nfactor #25

Open hvds opened 3 years ago

hvds commented 3 years ago

Hi Dana, not sure if you would want this change, it modifies add_factor to take a count.

I'd expect it to give a slight improvement for random numbers, but nothing huge. I think it also reduces complexity slightly, since there are several points in the code where you have to ADD_FACTOR iteratively.

danaj commented 3 years ago

I intentionally left the poly data out of the MANIFEST, as it would double the size of the distribution. I would like to see the class polynomials compressed or better yet efficiently generated, but I don't see that happening soon.

I like the change to add_factor.

hvds commented 3 years ago

I intentionally left the poly data out of the MANIFEST, as it would double the size of the distribution. I would like to see the class polynomials compressed or better yet efficiently generated, but I don't see that happening soon.

Ok, I added it only because I saw a complaint during make distclean.

I like the change to add_factor.

Cool, let me know if you'd like me to repush without the MANIFEST change.