Open danaj191 opened 7 years ago
Hi James, here are some comments:
Please create a folder "hw02" to put all related files. Also create a README file for this folder. The will make your repo look more clean and organized.
It would be better if you can organize your code by using bullet points/sections/headers. Because it is a little bit hard to match what you did with the questions that were asked.
Other than the code, maybe write down some observations?
Good job hitting most of the elements.
Good reflections and thanks for reminding us what not to do.
Thanks, Yidie
Smell test of data: Yes
Explores at least one categorical/quantitative variable: Yes
Uses various plot types: Histogram (base), scatterplot (base and ggplot)
Uses filter()
, select()
, and %>%
: Partial: no select()
Bonus (evaluate code, tables, more dplyr): No.
Reflection on process: Yes
Comments:
The document could use more text to guide the reader.
Avoid saving a subset of a dataset. Eg, use hist(gapminder$lifeExp)
instead of
y <- gapminder$lifeExp
hist(y)
If you do save a subset of a dataset, make sure to give it a more descriptive name than y
. This affects the graph titles, too!
arrange()
doesn't affect graphs.
Try making a different type of graph in ggplot.
Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.
Hi James,
Nice job on the assignment. You did a good job answering the questions and showed knowledge of dplyr functions and syntax, including piping, as well as ggplot2 functions. Your reflections were useful and earnest - I've also had issues reorganizing my repo, it can get confusing.
You could've been more creative with your graphical exploration - ggplot2 has many different ways of displaying data! Your markdown document also could've had some comments/links to tutorials. Overall though, nice work!
Best, Rainer
@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho
thanks!