search

danak6jq / RAK3172

Port of STM32WLxx example for RAK3172
30 stars 11 forks source link

Fixed sequencer bug #7

Closed IvanAmg closed 2 years ago

IvanAmg commented 2 years ago

Just added a few code lines in lora_app.c. If I'm not wrong, this issue is more related to how the sequencer and timer work instead of the Data Rate. Anyway, I'll appreciate any corrections.

danak6jq commented 2 years ago

Hello @IvanAmg - I checked the V1.2FW merge I'd done and found issues, in particular I re-merged lora_app.c. I went ahead and pushed this into the master branch; perhaps you'd like to pull that and confirm that it solves the issue reported here?

It also fixes (I think) battery status reporting on the RAK5005.

IvanAmg commented 2 years ago

Seems like there are some conflicts with the new commits, should I close this PR and try to pull?

danak6jq commented 2 years ago

I would suggest yes. Go ahead and pull; I expect this will solve the issue you first reported (and some others). I appreciate the work you did on this, and it prompted me to have a closer look and realize I didn't do a good merge first time around.