Murder Mystery (PWP) - Githubissues

Criteria 1: Valid Python Code

Score Level: 4
Comment(s): Code included runs without any errors.

Criteria 2: Implementation of Project Requirements

Score Level: 4
Comment(s): Code produces the suite of functions and classes required of it and calls them in an appropriate order.

Criteria 3: Software Architecture

Score Level: 4
Comment(s): Code is separated into distinct classes and functions each which are invoked for their own purposes.

Criteria 4: Uses Python Language Features

Score Level: 3
Comment(s): Python language features are usually used, but there are 1-3 cases of a coded construction could have been accomplished by a Python builtin.

Criteria 5: Produces Accurate Output

Score Level: 4
Comment(s): Code output is properly formatted and accurate.

Overall Score: 19/20

Overall, excellent work with this project! You did a great job in all aspects of the project, from implementing the project requirements to using Python specific features when applicable. Good job with that!

I just wanted to point you to a string processing module that's included with Python that may be useful for certain aspects of this project, especially with the prepare_text method. There is a module called re that allows you to do regular expression operations in Python. With this module, we can actually complete what is done in the following function:

def prepare_text(text):
    prepared_text = []
    lowercase = text.lower()    
    newtext = lowercase.split()
    for word in newtext:
        strip_dot =  word.strip('.')
        strip_exclamation = strip_dot.strip('!')
        strip_question = strip_exclamation.strip('?')
        strip_comma = strip_question.strip(',')
        prepared_text.append(strip_comma)

    return prepared_text

With a single line of code instead. You can look at this resource for more information about that (you can look at the accepted answer). You can also read more about the re module here.

Great job overall! I hope you enjoyed the course!

danalittleskier / murder_mystery