search

danalloway / react-country-flag

React component for emoji/svg country flags.
https://danalloway.github.io/react-country-flag/
MIT License
255 stars 43 forks source link

Added undefined/null check to title attribute #20

Closed dbengtsson closed 4 years ago

dbengtsson commented 5 years ago

Since empty strings are falsy in javascript, passing an empty title attribute will display the country code instead. In order to be able to disable the title altogether the component needs to accept empty strings.

(Should this be done for the emoji thing as well? It currently doesn't use title at all)