search

danalloway / react-country-flag

React component for emoji/svg country flags.
https://danalloway.github.io/react-country-flag/
MIT License
255 stars 43 forks source link

Update to work with React 17 #39

Closed acolle closed 3 years ago

acolle commented 3 years ago

Would it be possible to update the project to work with React 17? It's currently only accepting version 15 or 16. Thanks

skipjack commented 3 years ago

Ran into this as well. You can get past the npm v7 error like so...

npm i --legacy-peer-deps react-country-flag

Package appears to be working fine as far as I can tell, not seeing any glaring breaking changes that would have an effect here. Still would be nice to bump the peerDependencies here though.

TomlDev commented 3 years ago

Yea would be cool to get this!

$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: product-configurator@0.2.4
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from react-country-flag@2.3.0
npm ERR! node_modules/react-country-flag
npm ERR!   react-country-flag@"^2.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
dylan-13 commented 3 years ago

Yeah please update it to work with V17 of React 🛐

dylan-13 commented 3 years ago

Following the release of version 2.3.1 you can close this issu, @danalloway 🛐

danalloway commented 3 years ago

thanks @dylan-13 ! closing after this commit ed369627e8e050ec14fd194a9c9073495f8e4263