danalloway / react-country-flag

React component for emoji/svg country flags.
https://danalloway.github.io/react-country-flag/
MIT License
248 stars 43 forks source link

Country flags missing for Kosovo (XK) and Netherland Antilles (AN) #5

Closed joshlbaker closed 5 years ago

joshlbaker commented 6 years ago
danalloway commented 6 years ago

ACK. I'll take look into this as soon as I'm able. Thanks for reporting this.

joshlbaker commented 6 years ago

Amazing, thank you!

danalloway commented 5 years ago

@joshlbaker haven't forgotten about this, will have something in during the holiday break most likely

joshlbaker commented 5 years ago

@danalloway the CDN you were using to import the flag svgs has been updated with these flags so all you should need to do is update that to the latest 3.2.1

https://github.com/danalloway/react-country-flag/blob/master/src/index.js#L14 https://github.com/lipis/flag-icon-css

danalloway commented 5 years ago

using latest CDN v3.2.1 as of our release 1.0.2

LCCalado commented 5 years ago

I am using the latest version (1.0.2) and I am still getting 404 on 3 flags:

GET https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.2.1/flags/4x3/kv.svg 404 GET https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.2.1/flags/4x3/an.svg 404 GET https://cdnjs.cloudflare.com/ajax/libs/flag-icon-css/3.2.1/flags/4x3/ic.svg 404

danalloway commented 5 years ago

@LCCalado yea that is correct, can't do much about that also, the ISO country code for Kosovo is XK not KV give that a try https://github.com/lipis/flag-icon-css/blob/master/flags/4x3/xk.svg

LCCalado commented 5 years ago

Thanks. What about "Netherland Antilles" and "Canary Islands"?

danalloway commented 5 years ago

I don't maintain the Flag library so I'm not sure why they are not included, there are no emoticons for them either. I would recommend a custom solution for those edge case flags.

vincentsartoko commented 2 years ago

I don't maintain the Flag library so I'm not sure why they are not included, there are no emoticons for them either. I would recommend a custom solution for those edge case flags.

@danalloway Can you guide me on how to put custom flags? Thank you :)