search

danalloway / react-country-flag

React component for emoji/svg country flags.
https://danalloway.github.io/react-country-flag/
MIT License
255 stars 43 forks source link

Stars element on US flag misplaced #61

Closed eirikhanasand closed 1 year ago

eirikhanasand commented 1 year ago

The star element on the US flag is misplaced. This causes a big issue in React Native, where the stars will be misplaced in the top left corner, with one row half way outside the flag.

Browser inspection:

us

As you can see the star element is off by a tad bit. This looks fine in the browser, but when trying to use it in React Native it breaks. (I know this is a react library, but it is still a bug that just so happens to look fine in the browser, and there will be no negative consequences in fixing it)

React native result:

us2

Properly placing the star element should fix things in React Native, and fix an unnoticed bug.

danalloway commented 1 year ago

@eirikhanasand thanks for your feedback!

the flag SVGs come from this library https://github.com/lipis/flag-icons, I'd suggest bringing up this issue over there