search

danarin21 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

CSS styling, responsiveness, and repeated code #4

Open aubreywullschleger opened 7 years ago

aubreywullschleger commented 7 years ago

Great!/Simplify! As for your CSS, nice styling choices for your fonts and colors. Also, awesome job with the responsiveness of your site, your use of flex-box and media queries is phenomenal. The only thing I would challenge you to do in your CSS is to clean up some of the repetitive styles. For example you should be grouping your selectors that have use the same font-family and font-weight. Example, for lines 17-32 you could use: 

h1, h2, h3 {
  font-family: 'Josefin Slab', serif;
  font-weight: 600;
}

h2 {
  font-size: 2.25rem;
}

h3 {
  font-size: 1.5rem;
}

https://github.com/danarin21/f1-3-c2p1-colmar-academy/blob/master/dariniello_colmar-academy-submit/resources/css/style.css#L17-L32