search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

[Tests] Use the modern ReactDOM.render+findDOMNode APIs for React 15 #10

Closed ide closed 8 years ago

ide commented 8 years ago

React 0.14 introduced these two new methods, and React 15 made them the only want to render elements and find DOM nodes so the test suite was failing. This commit adds react and react-dom to package.json's devDependencies (since the tests require them) and updates the tests to use the new API.

Fixes #9

Test Plan: npm test passes.

danawoodman commented 8 years ago

Thanks @ide! What impact will this have on pre-0.14/0.15? I would imagine it would make it backwards incompatible?

ide commented 8 years ago

No change to users of this library. It's just the tests that require React 0.14+.

danawoodman commented 8 years ago

Doh, should have looked at the PR first!

danawoodman commented 8 years ago

Thanks again @ide!