search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

Icons don't display #16

Closed timfpark closed 8 years ago

timfpark commented 8 years ago

In my hands, after doing an install with:

npm install --save react-fontawesome

I am not able to see any icons by including something like this in one of my views:

<FontAwesome name='bars' />

unless I also include Font Awesome's CDN .js in the tag, ala:

<script src="https://use.fontawesome.com/3bd7769ce1.js"></script>

Are there any other installation steps required beyond the npm package? Or is this a bug?

I'm using React 0.15 with react-fontawesome 1.1.0.

danawoodman commented 8 years ago

On first look, I would assume that you're not including the CSS?

I'll have a look at this in more detail later today too

timfpark commented 8 years ago

That's right - it sounds like what I am doing then is actually the right way of going about it (for the CDN based approach) - if so go ahead and close this out.

danawoodman commented 8 years ago

@timfpark I'm not familiar with the FA javascript CDN but you could use this one instead: https://www.bootstrapcdn.com/fontawesome/

timfpark commented 8 years ago

Thanks @danawoodman!

danawoodman commented 8 years ago

@timfpark you're welcome 👍

novotnej commented 7 years ago

It would be nice if you could add this information to the readme, so that fewer of us have to waste time figuring it out?

Cheers

danawoodman commented 7 years ago

@novotnej this information is in the readme:

If you think it should be elsewhere I would accept a PR for it

novotnej commented 7 years ago

My apologies, didn't notice it there. I created a PR where I moved it to the install section, I think it should rather be there than at the end of features..

danawoodman commented 7 years ago

That's a better spot for it, thanks!