Closed n3v3rf411 closed 7 years ago
Hi, <span>
may be the preferred tag but <i>
is also used a LOT. In my particular case, I need to be able to customise the tag to match a vendor's CSS so I can style things correctly.
@hassankhan so the vendor is using the tag name instead of class name to select the icon? Damn vendors! 😉
I'd be open to merging this if we could address the two things I mentioned in the commit!
I'm ... actually not the author of the PR, I do agree with you on changing component
to tagName
and adding tests for it.
Oooops I totally forgot about this PR. I have the same reasons with @hassankhan. We are using AdminLTE and it uses <i>
alot for fontawesome icons. Most CSS selectors esp. the sidemenu use element>element
selectors.
I will apply the changes above and resubmit the PR tomorrow.
Lol sorry @hassankhan! @n3v3rf411 could you make those small tweaks and I'll merge? Thanks!! 🍻
@n3v3rf411 if you can make those tweaks above I will merge 👍
@n3v3rf411 let me know if you can make those changes :)
Closing this until PR is updated
Hi @n3v3rf411 thanks for the PR. What is the intention/goal of making this change? From what I can tell,
<span>
is the preferred tag here since<i>
is semantically meant to indicate italic text. I know people sometimes prefer<i>
but what is the practical reason for such a change other than preference?