search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

Consider using aria? #20

Closed Phyks closed 7 years ago

Phyks commented 8 years ago

Hi,

Would be awesome if accessibility features were wrapped as well. That is using aria-hidden=true and providing a prop to pass an alternate text to put either in an aria-label or a hidden <span>.

Thanks!

EDIT: I can make a PR for this if you are ok for a review and eventual merge.

danawoodman commented 8 years ago

@Phyks yeah that would be great, PR totally welcome! 👍

Phyks commented 7 years ago

Sorry, I got really busy lately and missed this one :/ Here is a PR :)