Closed lucaskatayama closed 7 years ago
Done...
@lucaskatayama quick work! One last request, could you add a small test for the new feature? Thanks!!
Done...
I was getting a “Cannot render markup in a worker thread” error. Don't know what is this, so I use this solution
Looks like the build is breaking. Perhaps instead of using that import you could wrap the font awesome tag with a <div>
instead?
I did it... But I don't understand why it worked ...
Thanks @lucaskatayama! Merging 🍻
FYI, I think it needed a parent node since we're running tests in a non-browser environment (eg no <body>
tag
humm... but why the other test didn't fail?
Not 100% sure, let me know if you figure it out 😄
Release in v1.3.1
on npm!
LOL... XD
@lucaskatayama thank you for the PR! Noticed that api.md is now gone, can you undo that change? If you fix that, I will merge this!