search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

Adding possibility to change tag #28

Closed lucaskatayama closed 7 years ago

danawoodman commented 7 years ago

@lucaskatayama thank you for the PR! Noticed that api.md is now gone, can you undo that change? If you fix that, I will merge this!

lucaskatayama commented 7 years ago

Done...

danawoodman commented 7 years ago

@lucaskatayama quick work! One last request, could you add a small test for the new feature? Thanks!!

lucaskatayama commented 7 years ago

Done...

I was getting a “Cannot render markup in a worker thread” error. Don't know what is this, so I use this solution

http://stackoverflow.com/a/26872245/1181036

danawoodman commented 7 years ago

Looks like the build is breaking. Perhaps instead of using that import you could wrap the font awesome tag with a <div> instead?

lucaskatayama commented 7 years ago

I did it... But I don't understand why it worked ...

danawoodman commented 7 years ago

Thanks @lucaskatayama! Merging 🍻

danawoodman commented 7 years ago

FYI, I think it needed a parent node since we're running tests in a non-browser environment (eg no <body> tag

lucaskatayama commented 7 years ago

humm... but why the other test didn't fail?

danawoodman commented 7 years ago

Not 100% sure, let me know if you figure it out 😄

danawoodman commented 7 years ago

Release in v1.3.1 on npm!

lucaskatayama commented 7 years ago

LOL... XD