danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

use prop-types package instead of deprecated React.PropTypes #40

Closed corime closed 7 years ago

corime commented 7 years ago

this adds another dependency but avoids deprecation warnings/errors once React.PropTypes are removed (see https://facebook.github.io/react/docs/typechecking-with-proptypes.html)

danawoodman commented 7 years ago

Thanks @coremi! Do you think this warrants a major version push? Will this break anything?

corime commented 7 years ago

Now it's a dependency instead of a peerDependency, and won't break anything. If it's ok for you? (for a major version push... I don't know, it just removes a deprecation warning, that only appears if a very new react version >=15.5 is used)

danawoodman commented 7 years ago

Thanks @coremi!