search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
667 stars 72 forks source link

Fix typo #46

Closed server-monitor closed 7 years ago

danawoodman commented 7 years ago

@server-monitor thanks for the fix!

It's probably not obvious, but this typo can actually be found in here: https://github.com/danawoodman/react-fontawesome/blob/master/src/index.js#L17

Since the api.md is automatically generated, we need to fix it in the JSDocs instead 😄

If you fix that line and then run npm run dist and commit the changes, I'll happily accept this PR!

danawoodman commented 7 years ago

Closing until I get a reply from @server-monitor

server-monitor commented 7 years ago

Sorry I lost track of this.

On Thu, May 25, 2017 at 1:28 PM, Dana Woodman notifications@github.com wrote:

Closed #46 https://github.com/danawoodman/react-fontawesome/pull/46.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/danawoodman/react-fontawesome/pull/46#event-1097947687, or mute the thread https://github.com/notifications/unsubscribe-auth/ARG9m-S53tRUElTnS8lUernHn_wGqpp3ks5r9eSEgaJpZM4NaWeX .

danawoodman commented 7 years ago

@server-monitor no problem, feel free to update and reopen and I will merge 😄