search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
668 stars 72 forks source link

Font Awesome 5 compatibility #63

Closed fabriceci closed 6 years ago

fabriceci commented 6 years ago

Font Awesome 5 is out and change a bit the class names.

danawoodman commented 6 years ago

This will require a bit of change to the API but a proposal or PR is welcome

frinyvonnick commented 6 years ago

@danawoodman is someone working on this issue ? If not i'll do it 😄

danawoodman commented 6 years ago

@frinyvonnick go for it! Keep in mind that Font Awesome already has their own React component for v5 now

frinyvonnick commented 6 years ago

Oh didn't know it 😕. You are referring to this repository https://github.com/FortAwesome/react-fontawesome ? I'll study this one and if it doesn't fit my needs I will make a pull request. Thanks for the information 👍

danawoodman commented 6 years ago

Exactly. Unless react-fontawesome does things the official one doesn't do, I would say go with the official. If you do end up wanting to do a PR, I think we could accomplish it by adding some boolean properties:

<FA name="rocket" solid />
<FA name="rocket" regular />
<FA name="rocket" light />
danawoodman commented 6 years ago

Re-open if you think you'll do a PR!