danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
668 stars 72 forks source link

Add support for FontAwesome ul > li bullets #68

Closed jlnewton87 closed 4 years ago

jlnewton87 commented 6 years ago

Could have used className and prepended list item with base FontAwesome component, but that would have been messy. I also cleaned up the class composition, which required another function to prune the props that are going to be passed onto the root elements.

Let me know what you think. If you'd prefer to build the class list for each component while maintaining the cssModule support, then I can remove those bits - I just think it reads better this way and cleans up the components.

danawoodman commented 4 years ago

Really appreciate the PR but I'm unfortunately not able to spend much time on this especially since FontAwesome now has their own official component. I'm going to close this for now but if you feel like updating and fixing the merge conflicts I can work to merge it in. Thanks again for your time!