search

danawoodman / react-fontawesome

A React Font Awesome component.
https://www.npmjs.com/package/react-fontawesome
MIT License
668 stars 72 forks source link

feat(docs): add create-react-app sections #71

Closed blaskovicz closed 5 years ago

blaskovicz commented 6 years ago

This includes information about yarn usage, suggestions for webpack bundling, and an example for usage.

blaskovicz commented 6 years ago

@danawoodman create-react-app is an immensely popular scaffolding that wraps and abstracts webpack. From their docs:

You don’t need to install or configure tools like Webpack or Babel. They are preconfigured and hidden so that you can focus on the code.

Scaffolded apps don't have direct config access unless you eject.

Since many people start with that scaffold and probably don't use eject, I figured it would be useful to have examples specifically tailored to create-react-app and yarn. Thoughts? Should I proceed with addressing the other points in the pull request?

danawoodman commented 6 years ago

@blaskovicz yeah, I am aware of react-create-app and it's configuration. I guess what I'm wondering is how is it different than the existing setup? Don't you just do the following?

import "font-awesome/css/font-awesome.css";

If so, that is covered in the docs I mention in the readme.

If you were to add a section on react-create-app, I would hope it wasn't the first part of the docs and was much more simplified as I feel like the changes make the docs more verbose without a lot more clarity. If you'd like, maybe just focus on a sub section under setup that just makes a note of using it with react-create-app. Having extra install info, etc doesn't help in my opinion. Thoughts?

danawoodman commented 5 years ago

Closing because of inactivity