Closed ide closed 8 years ago
cc @danawoodman @amsardesai could one of you guys take a look at these commits when you get a chance? Thanks =)
Thanks again @ide I will review these all shortly and get back to you, sorry for the delay (messages missed my inbox!)
Thanks @ide, merged! 👍 😃
@danawoodman thanks for the review! Do you think you could publish a new version to npm sometime?
@ide this in the newly published v1.0.0 on npm!
Thanks :)
No, thank you! I welcome any more additions/changes you have 😸
Previously the JSX splat syntax was used to pass
this.props
in its entirety into the underlying<span>
component. This resulted in invalid HTML markup because thename
prop was rendered in the markup, and according to the W3 HTML checker it's invalid to have aname
prop on a<span>
in most contexts.So instead, we split out the FontAwesome-specific props from the rest of them, and pass only the non-FontAwesome props down to the
<span>
.Test Plan: Added a regression test