search

danawoodman / sinon-express-mock

Simple request and response mock objects to pass into Express routes when testing using Sinon.
https://www.npmjs.com/package/sinon-express-mock
MIT License
47 stars 16 forks source link

Unmet peer dependecy: sinon@5.0.7 #10

Closed wu-lee closed 6 years ago

wu-lee commented 6 years ago

I gather sinon-express-mock currently lists sinon ^4.1.3 as a peer dependency.

Sinon's current release is now 5.0.7.

Is there a plan to update to, or otherwise allow current Sinon releases? Or do I need to downgrade Sinon to use sinon-express-mock?

Thanks!

danawoodman commented 6 years ago

Someone had updated this previously in a PR but I forgot to push the code to NPM. Can you try v2.0.2 and reopen if it still doesn't work?

wu-lee commented 6 years ago

I don't think I can reopen this, but I think it is still unresolved: package.json's peerDependencies is still configured as ^4.1.3.

danawoodman commented 6 years ago

Fixed in v2.0.4 👍