peerDependency warning for sinon@4.1.3

danawoodman / sinon-express-mock

Simple request and response mock objects to pass into Express routes when testing using Sinon.

https://www.npmjs.com/package/sinon-express-mock

MIT License

47 stars 16 forks source link

peerDependency warning for sinon@4.1.3 #8

Closed jimmycann closed 6 years ago

jimmycann commented 6 years ago

Hi there!

Pleased to be using your library in our project, however I keep receiving peerDep warnings from npm

npm WARN sinon-express-mock@2.0.0 requires a peer of sinon@4.1.3 but none is installed. You must install peer dependencies yourself.

We're using sinon@4.5.0 and this library still works a treat. Would it be alright if the peerDep was changed to "^4.1.3" to catch the other minor versions in sinon v4? Submitting a PR for this one now

danawoodman commented 6 years ago

Great idea, thanks!