danb35 / deploy-freenas

Python script to automate deploying TLS certificates to FreeNAS servers
GNU General Public License v3.0
202 stars 56 forks source link

checking for CSR before remove #37

Closed XpycTee closed 3 years ago

XpycTee commented 3 years ago

Hello. I noticed that when there is a CSR in the list of certificates, the script throws an exception:

Traceback (most recent call last): File "./deploy_freenas.py", line 192, in issued_date = datetime.strptime(cert_data['from'], "%c") TypeError: strptime() argument 1 must be str, not None

I added a check on whether the certificate being checked is a CSR and if so then don't add it to the expired list

P.S. I hope I didn't break anything too much and my PR will be useful, this is my first PR