danb35 / deploy-freenas

Python script to automate deploying TLS certificates to FreeNAS servers
GNU General Public License v3.0
203 stars 56 forks source link

More fine-grain control which certificates to update #40

Closed OidaTiftla closed 3 years ago

OidaTiftla commented 3 years ago

Hi danb35,

I found your script and it was really helpful to me.

I made a small change, because I had the problem, that I use different certificates (because of different subdomains) for the different services: UI, webdav and ftp.

So I introduced a new setting called update_ui and renamed the two existing settings ftp_enabled -> update_ftp and webdav_enabled -> update_webdav. The rename was done because of readability (the services are enabled on my FreeNAS installation, but I wanted to select individually which certificate gets deployed to which service).

So my setup is the following:

Please let me know if this is something you want to integrate into your version. And if you are okay with the new settings names, or if I should rename them to something else.

Thank you and have a nice day πŸ˜ƒ

danb35 commented 3 years ago

Pardon if this is a dumb question, but why not just put all three subdomains on the same certificate?

OidaTiftla commented 3 years ago

Okay, that's a very good question I've not thought about that πŸ™ˆ

Thanks for this tipp, I'm closing this now.