search

danb35 / deploy-freenas

Python script to automate deploying TLS certificates to FreeNAS servers
GNU General Public License v3.0
199 stars 56 forks source link

feat: update scale apps their certificate id #51

Closed subutux closed 2 years ago

subutux commented 2 years ago

This looks trough the deployed scale apps and checks if the ingress is enabled and TLS is active. If so, update the certificate ID to the new one.

AidanGG commented 2 years ago

I'm receiving the following error (TrueNAS-SCALE-22.02.2.1):

Traceback (most recent call last):
  File "/root/deploy-freenas/./deploy_freenas.py", line 280, in <module>
    if config['ingress']['main']['enabled'] and len(config['ingress']['main']['tls']) > 0:
KeyError: 'ingress'

Perhaps something changed in a recent SCALE update?

subutux commented 2 years ago

Hi,

I noticed the same issue. If I got the time later today, I'll take a look. I don´t think this has anything todo with a recent update because I didn't upgrade, just a coding error in detecting if a scale app is using the TLS setting.

maybe a quick fix can be to change the line 280 to the following:

if config.get("ingress", False) and config['ingress']['main']['enabled'] and len(config['ingress']['main']['tls']) > 0:

That should fix the issue. I can´t test it right now tho.

AidanGG commented 2 years ago

That seems to fix my issue, thanks!