search

danb35 / freenas-iocage-heimdall

Script to install Heimdall Dashboard in a FreeNAS iocage jail
BSD 2-Clause "Simplified" License
11 stars 3 forks source link

Added parameter to set netmask #2

Closed thunfischbrot closed 3 years ago

thunfischbrot commented 4 years ago

Allows for netmasks other than /24.

danb35 commented 4 years ago

Custom netmask is a good idea, but I'd rather allow the user to specify the IP in CIDR format and use that netmask if present. See https://github.com/danb35/freenas-iocage-nextcloud/commit/aca78e0910772f73149e3b6c03eb8cbafd5cecc7 for how that was done with the Nextcloud script.

And, of course, it should also be documented.

danb35 commented 3 years ago

This is addressed with #4 .