search

danb35 / freenas-iocage-nextcloud

Script to create an iocage jail on FreeNAS for the latest Nextcloud 28 release, including Caddy, MariaDB or PostgreSQL, and Let's Encrypt
GNU General Public License v3.0
258 stars 71 forks source link

fix bug #104

Closed jsmith8954 closed 4 years ago

danb35 commented 4 years ago

There's a lot of stuff going on in this former PR that isn't any sort of a bug fix, and I'm not seeing anything that is actually fixing a bug. It'd be better to have one PR for one issue, with a clear description of what each PR does.

jsmith8954 commented 4 years ago

sorry about this, i forked the repo so i could play with the script, didn't intend to create a PR against your repo

jsmith8954 commented 4 years ago

i was actually trying to start from https://github.com/danb35/freenas-iocage-nextcloud/pull/96 (all those changes aren't actually mine)

however the bug fix (i noticed it last night, he has the fix in his PR) is with setting the CONFIG_PATH, it actually overwrites the FILES_PATH, if not set on line 125