search

danb35 / freenas-iocage-nextcloud

Script to create an iocage jail on FreeNAS for the latest Nextcloud 28 release, including Caddy, MariaDB or PostgreSQL, and Let's Encrypt
GNU General Public License v3.0
258 stars 71 forks source link

NO_CERT=1 stil requires CERT_EMAIL #113

Closed Ramblurr closed 4 years ago

Ramblurr commented 4 years ago

I'm provisioning certs myself with a transparent proxy.

I set NO_CERT=1 and didn't set any of the other cert settings.

After the script finished, caddy wasn't started, and wouldn't start because the CERT_EMAIL setting wasn't set:

# service caddy restart
rc variable $caddy_cert_email is not set. Please provide a valid SSL certificate issuer email.
danb35 commented 4 years ago

wouldn't start because the CERT_EMAIL setting wasn't set:

That's correct, and documented in the README:

This is mandatory regardless of whether you're using Let's Encrypt (Caddy won't start without it), but it's only used with Let's Encrypt.

I thought I had a check for that in the script; if not, I'll need to add it.