Optional changes - Githubissues

danb35 / freenas-iocage-nextcloud

Script to create an iocage jail on FreeNAS for the latest Nextcloud 28 release, including Caddy, MariaDB or PostgreSQL, and Let's Encrypt

GNU General Public License v3.0

252 stars 71 forks source link

Closed basilhendroff closed 3 years ago

basilhendroff commented 3 years ago

Improve readability and code reusability.

danb35 commented 3 years ago

What you're doing with the nextcloud-config file seems logical, but I have two concerns:

$SCRIPTNAME seems like it should refer to the name of the running script, not to its config file.
This may be more a style preference, but I think "${SCRIPT_PATH}"/"${CONFIG_NAME}" would at least look better than "${SCRIPT_PATH}/${CONFIG_NAME}". I'm not sure if there'd be any functional difference, though.

basilhendroff commented 3 years ago

Agree.

basilhendroff commented 3 years ago

I've made the suggested changes.