Closed PrivatePuffin closed 4 years ago
Hence, calling the directory containing temporary files for the install process "configs" is needlessly confusing.
Why or how is it confusing? It's only used by the script itself, its path is hard-coded (so it isn't an option in the nextcloud-config
file to confuse a user), it's only used temporarily, and it's removed from the jail's fstab once installation is complete. I'm not married to the current directory name, and I'm willing to consider changing it, but I don't think I'm seeing the problem you're suggesting.
@danb35 There is such a thing in opensource as: "other people working on your code". ;)
I find it confusing having to either rename my own config directory structure to not be confusing or I found it messy and needlessly confusing. I might've more fixed and such in the pipeline for this repo and calling this "configs" might/will affect readability in the long run.
Normally these things are refered more as "includes" than "configs" imho...
TO-BE-REPLACED
Some users (also) create datasets and/or symbolic links for the actual in-application config directory ('/usr/local/www/nextcloud/config' in this case).
Hence, calling the directory containing temporary files for the install process "configs" is needlessly confusing.
This PR renames "configs" to "includes", refering to the fact those are the files "included" with the buildscript.