danb35 / freenas-iocage-nextcloud

Script to create an iocage jail on FreeNAS for the latest Nextcloud 28 release, including Caddy, MariaDB or PostgreSQL, and Let's Encrypt
GNU General Public License v3.0
258 stars 71 forks source link

Add jail interfaces option to link vnet to different bridge #98

Closed PrivatePuffin closed 4 years ago

PrivatePuffin commented 4 years ago

This is a very small fix, that adds the option to set the (barely documented) "Interfaces" flag in iocage. This flag makes it possible to link VNETs to different bridges.

In practice this means one can route route the default VNET0, to a different bridge thats linked to a different VLAN, like this: vnet0:bridge99

For more info how this would work in practice, see the jails and vlans guide from Lawrence systems available here: https://www.youtube.com/watch?v=l6OsF5ppQnU&t=588s

This fixes #92

PrivatePuffin commented 4 years ago

@kleinarne If you could try and confirm this works, that would be great... I know it does, but just for completeness sake it would be nice having third party confirmation ;)

kleinarne commented 4 years ago

I will as soon as I can get around to it, hopefully later today.

Some thoughts:

I know the iocage parameter is called INTERFACES, but in the script's config it's confusing to have INTERFACE and JAIL_INTERFACES. Would it be better to use HOST_BRIDGE or is this better left for the Readme to explain?

What happens if I set INTERFACE="VNET1", will this break with the hard coded VNET0 for the INTERFACES parameter?

PrivatePuffin commented 4 years ago

@kleinarne Those are all advanced parameters, I don't expect anyone to mess with them. (people shouldn't)

If people start messing with them and it doesn't work out, i'm inclined to just say: you're on your own. We can't support everyones custom FreeNAS networking setup, thats what this is. Same with IXsystems: They also don't provide support for strange setups without a payday.

I'm not willing to go Ubiquiti and call things differently just because I can and users might understand it beter. KISS.

What happens if I set INTERFACE="VNET1", will this break with the hard coded VNET0 for the INTERFACES parameter?

Ofcourse it would, it would in FreeNAS and so would it here. There are a multitude of reasons i'm not going to force any INTERFACES config based on the INTERFACE selected. To solve this I need to fuck with people's custom setup, based on what I think is best. That is not, and should not be, up to me

Edit If dan want's it differently, he can do so himself. It's just a quick fix based on how I do things myself in my script. For a multitude of reasons I removed this part of the script competely when integrating it into jailman, so i'm not interested in providing further support on it here ;)

PrivatePuffin commented 4 years ago

@danb35 If you are not interested in merging, please just say so and close the PR so I can delete my branch.

PrivatePuffin commented 4 years ago

@danb35 Thanks! :)