danb35 / freenas-iocage-plex

Scripted installation of Plex Media Server in a FreeNAS jail
GNU General Public License v3.0
56 stars 9 forks source link

How do you feel about creating a dataset for plex_data? #4

Closed thorsteneb closed 4 years ago

thorsteneb commented 4 years ago

Your script currently makes a directory if a dataset matching PLEX_CONFIG_PATH doesn't exist. How do you feel about creating the dataset instead? Or would you rather leave that as a deliberate action for the user, outside the script?

danb35 commented 4 years ago

I remember discussing this previously, probably with Basil on one of the forum threads. No, I don't want to be creating datasets in the script--if the user wants PLEX_CONFIG_PATH to be its own dataset, the user will need to create that dataset first. I did recently update the README to discuss this, though.