search

danbarua / NEventSocket

A reactive FreeSwitch eventsocket library for Modern .Net
Mozilla Public License 2.0
74 stars 37 forks source link

ApiResponse: Is "-ERR no reply" an error? #55

Closed pragmatrix closed 8 years ago

pragmatrix commented 8 years ago

-ERR no reply should probably not be treated as an error in ApiResponse. I'd suggest to set Success to true and add another property IsNoReply that indicates this specific response state.

danbarua commented 8 years ago

From skimming the FreeSwitch source code, it does look that way.

https://github.com/danbarua/NEventSocket/blob/master/src/NEventSocket/Sockets/EventSocket.cs#L151

danbarua commented 8 years ago

I think it's ok to just treat -ERR no reply as a success.

pragmatrix commented 8 years ago

Very good, thank you Dan!