search

danbarua / NEventSocket

A reactive FreeSwitch eventsocket library for Modern .Net
Mozilla Public License 2.0
74 stars 37 forks source link

Support netcore #66

Open ti24horas opened 7 years ago

ti24horas commented 7 years ago

Hi,

Can you please take a look at this PR? I updated the project to support .net core (running on linux).

For what I tested (basic auth, say, play, hangup) it works as the .net 451 version.

I have some questions regarding the "Serializable" classes you have. Is the Serializable used to pass the object through tcp? From my tests, I can see it isn't used in the core library, but for third party consumers, this could be a break change as .NET Core does not support serialization yet.

Well, please take a look and tell me if I can help in anything.

danbarua commented 7 years ago

Get in mate! I will take a look at this tomorrow at work.

ti24horas commented 7 years ago

I didn't understood "This needs to go upstream in https://github.com/damianh/LibLog"

Is the LibLog an external dependency? The other question is regarding to memory leak problems you mencioned. I have a valid license of dotmemory and can help you. Just tell me the strategy you have in mind to troubleshoot it.

gregoriusus commented 6 years ago

Guys, anyone working on porting to net core?