Closed Sobonis01 closed 3 years ago
2 real quick github things, unrelated to your edits.
1) Its customary to let the reviewer mark a conversation as resolved. 2) You don't need to attach the file in a comment here, as once you make a commit locally and then push it the new file is available for the rest of us.
Is this one ready for review at this point?
Yes it is the one for review.
Cool, let's toss a "ready for review" label on it. You can find it under the labels dropdown on the left side of the screen.
I'll toss it on here and take a look here in a bit.
Ships as Raw.txt