stop building with Rust 1.20 in automation

danburkert / lmdb-rs

Safe Rust bindings for LMDB

Apache License 2.0

172 stars 87 forks source link

stop building with Rust 1.20 in automation #47

Closed mykmelez closed 5 years ago

mykmelez commented 5 years ago

The latest version of cc, version 1.0.27, requires str.trim_end_matches(), which was introduced in Rust 1.30, so this project won't build anymore with Rust 1.20. Thus we should stop building it with that version in automation.

(Alternately, we could pin cc to the previous version 1.0.26, but that seems undesirable, given that we want to continue to get future patch-level fixes to that crate.)

mykmelez commented 5 years ago

This ended up getting fixed in cc version 1.0.28 via https://github.com/alexcrichton/cc-rs/pull/365, so it's no longer necessary to stop supporting Rust 1.20.