More complete FileIO support

dancasimiro / WAV.jl

Julia package for working with WAV files

Other

85 stars 35 forks source link

More complete FileIO support #34

Closed staticfloat closed 8 years ago

staticfloat commented 8 years ago

This provides more complete FileIO support by transparently passing kwargs through to the internal wavread/wavwrite functions.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 68.75% when pulling 26d2c92ad81a6bb96e2ad888366ed13104520dd5 on staticfloat:sf/fileio into caf1478ceaf480a7ed9a556b8c3fb87769e5822b on dancasimiro:master.

dancasimiro commented 8 years ago

Thanks for the PR @staticfloat. Do you know why the tests are failing?

staticfloat commented 8 years ago

The tests are failing on master as well; it's because of array changes in 0.5; there are a wider set of classes that inherit from AbstractArray and so your type annotations should be expecting an AbstractArray, not just an Array, so that you can deal with subarrays and whatnot.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 68.75% when pulling 6c91b8435ffab94cf09648b39ca05cdd48f00cef on staticfloat:sf/fileio into caf1478ceaf480a7ed9a556b8c3fb87769e5822b on dancasimiro:master.

dancasimiro commented 8 years ago

I'm sorry, but I pushed a fix for the test failures before I noticed that you also fixed that problem in this pull request. Could you please rebase so that I can automatically merge this pull request?

Is this FileIO support sufficient that I can tag a release?

staticfloat commented 8 years ago

Rebase complete. It looks like there was still one method that needed to be moved from Array to AbstractArray

Yes, I think the FileIO stuff is feature-complete enough to publish a new version.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 68.75% when pulling d6b1bbf93311fa6070f18e6fa548f5a274a7492b on staticfloat:sf/fileio into fbb11f81c9f5e8fb5872e99ae874d2ede2f29adf on dancasimiro:master.