Closed ewolfe closed 6 years ago
Thanks @ewolfe I will check it out tonight after work 😀
@ewolfe Would you also update test cases to match the ISO feature?
You can run the test using npm test
(I installed rollup
in the latest that's the reason for lock file change in #18 )
Just pushed a commit that updates the tests.
I also noticed the following error about mixing yarn.lock and package-lock.json:
➜ calendar-dates git:(feat/add-iso-key) yarn
yarn install v1.9.4
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] 🔍 Resolving packages...
success Already up-to-date.
✨ Done in 0.80s.
Thank you for the update there @ewolfe. I've merged it right now.
I will update the code again & republish after removing package-lock.json
which I accidental created ever since I started using yarn
less.. 😅
I found this useful for the scenario where I wanted to highlight the current date and also an arbitrary "selected" date. For example:
Having the iso 8601 date makes this a lot easier to do :)
PS: I haven't update the test suite yet (I wanted to get your feedback first before spending the time on the tests).