search

dance2die / calendar-dates

📆 Get a list of calendar dates with no external dependencies.
https://www.npmjs.com/package/calendar-dates
MIT License
14 stars 3 forks source link

Fix iso8601 values #21

Closed ewolfe closed 6 years ago

ewolfe commented 6 years ago

Well, this is embarrassing. I don't know how I didn't notice this issue in my last pull request.

Problem:

The iso values were returning incorrect values (always mapped to the first day of the month, and not reflecting the previous or next months).

Solution:

This pull request. We perform the correct logic this time to show the correct iso8601 date.

–

PS It's not exactly DRY. So let me know if you want to take a cleaner approach.

dance2die commented 6 years ago

Let me test tomorrow before publishing

dance2die commented 6 years ago

Thanks @ewolfe.

I've published the merged version to NPM registry (v2.4.1)

ewolfe commented 6 years ago

Thanks! And sorry for not seeing this the first time around, I was moving a little too fast haha