search

dance2die / calendar-dates

📆 Get a list of calendar dates with no external dependencies.
https://www.npmjs.com/package/calendar-dates
MIT License
14 stars 3 forks source link

Convert the code-base to TypeScript #57

Open dance2die opened 5 years ago

dance2die commented 5 years ago

Migrate to TypeScript.

TypeScript is bae 💖.

claudiopedrom commented 4 years ago

Hi @dance2die are you currently working on this? 😌

dance2die commented 4 years ago

Hiya, @claudiopedrom.

Nope. I haven't worked on this library for awhile.
If you could migrate & PR, it'd be nice 😉

perry-mitchell commented 3 years ago

@dance2die I'd like to have a go of converting.. I'll submit a PR shortly.

EDIT: On a similiar note, I'd propose to remove the class definition in the index in favour of exporting functions - Classes don't transpile well and include a bit of bloat for compatibility. As I'm not sure of your target compatibility, I would recommend using just exported functions as it's simpler for your users to consume. This would necessitate a major version bump in my opinion - but I'd be interested to hear what you think about it :)