dancerfly / django-brambling

Event website manager, specifically designed for dance weekends or other events with multiple simultaneous tracks of classes.
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Charges made through an old Stripe account can't be refunded #909

Open harrislapiroff opened 6 years ago

harrislapiroff commented 6 years ago

This actually is totally reasonable behavior and probably a very uncommon case but it would be nice to handle more gracefully.

Steps to reproduce:

  1. As an event organizer: Set up a Dancerfly org and event with an attached Stripe account
  2. As a customer: Make any purchase worth money using a credit card
  3. As an event organizer: Disconnect the stripe account and attach a different one
  4. As an event organizer: Attempt to refund customer purchase
  5. Observe error like: No such charge: ch_1CjfMD2vWxXRcAO4Doeo4xOT

Proposed mitigations:

  1. Give a more informative error, like "This may happen if the purchase was made to a different stripe account than the currently connected one."
  2. Automatically mark transactions as non-refundable when an organizer changes the stripe account (Maybe with a suggestion: "Dancerfly no longer has access to this transaction. Refund it directly through your payment processor.")