search

dancerfly / django-brambling

Event website manager, specifically designed for dance weekends or other events with multiple simultaneous tracks of classes.
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Remove django-compressor #915

Open melinath opened 5 years ago

melinath commented 5 years ago

I have a hypothesis that django-compressor does not improve page load time significantly and would like to try to remove it. This would also involve finding a different way to compile sass to css or stopping using sass altogether.

harrislapiroff commented 5 years ago

Strongly agree here. I would love to use webpack. Webpack configuration is The Worst, but it offers the most flexibility for compiling frontend assets. We'd probably also have to alter our development and deploy processes to:

  1. make it easy to spin up webpack on dev machines (maybe in a container, so no fiddling with node necessary?)
  2. compile assets at deploy time. This might require containerized deployment, but maybe not. See my own app Congress Tweets for an example of a deploy process that involves pre-compiling assets on the machine performing the deploy. In that case I had to use containerized deployment and precompile assets because Heroku will simply clean up any files that aren't committed to the git repository under traditional deployments. However, since we're using S3 to serve static assets, we could plausibly compile them on Heroku where they'll be immediately sent to S3... (Even if we precompiled them, we'd probably actually want that to happen on a CI server, not on a dev machine.)